Opprydding fjerner ubrukt kode #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blommish
requested review from
charliemidtlyng,
stigebil,
hensol,
olekvernberg and
ma10s
hensol
approved these changes
Sep 16, 2023
| @@ -141,7 +135,7 @@ class SimuleringTjenesteImpl( | |||
| return simulering.beregningsPeriode.associateWith { beregningsperiode -> | |||
| beregningsperiode.beregningStoppnivaa.map { stoppNivå -> | |||
| stoppNivå.beregningStoppnivaaDetaljer.filter { detalj -> | |||
| detalj.typeKlasse == TypeKlasse.YTEL.name | |||
| detalj.typeKlasse == PosteringType.YTELSE.kode | |||
There was a problem hiding this comment.
Noen grunn til at du mener det er bedre å bruke PosteringType enn TypeKlasse?
There was a problem hiding this comment.
Har fjernet TypeKlasse som låg inne i https://github.com/navikt/familie-oppdrag/pull/634/files#diff-c6739eda35315114a50a84630e890c9f48b6d60371f69f6f0630695cf4ba9cd2L44
Men som egentlige finnes i Kontrakter som PosteringType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vi kommer sansynligvis kopiere oppdrag fra familie, og tenkte då att det kunde være fint. få ryddet opp litt i den..
Dette er endepunkter som ikke er i bruk, har heller ikke vært i bruk siste 3 månadene.