Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fjerner ubrukt org.sonarsource.scanner.maven:sonar-maven-plugin #661

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Fjerner ubrukt org.sonarsource.scanner.maven:sonar-maven-plugin #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c1db7
Bump org.sonarsource.scanner.maven:sonar-maven-plugin
dependabot[bot] Jan 25, 2024
c733b51
Fjerner sonar
stigebil Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/build-and-deploy-preprod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,10 @@ jobs:
java-version: 21
distribution: 'temurin'
cache: 'maven'
- name: Bygg med maven + sonar
- name: Bygg med maven
env:
SONAR_PROJECTKEY: ${{ secrets.SONAR_PROJECTKEY }}
SONAR_LOGIN: ${{ secrets.SONAR_LOGIN }}
GITHUB_USERNAME: x-access-token
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# run: mvn -B --no-transfer-progress package verify sonar:sonar --settings .m2/maven-settings.xml --file pom.xml
run: mvn -B --no-transfer-progress package verify --settings .m2/maven-settings.xml --file pom.xml
- name: Bygg Docker image
run: |
Expand Down
29 changes: 0 additions & 29 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@
<cxf.version>4.0.2</cxf.version>

<mockk.version>1.13.5</mockk.version>
<!--suppress UnresolvedMavenProperty Ligger som secret i github-->
<sonar.projectKey>${SONAR_PROJECTKEY}</sonar.projectKey>
<sonar.organization>navit</sonar.organization>
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
<sonar.coverage.exclusions>**/config/FlywayConfig.kt,**/OppdragServiceE2E.kt
</sonar.coverage.exclusions>
<!--suppress UnresolvedMavenProperty Ligger som secret i github-->
<sonar.login>${SONAR_LOGIN}</sonar.login>
<spring-cloud.version>2023.0.0</spring-cloud.version>
<testcontainers.version>1.19.3</testcontainers.version>
<tjenestespesifikasjoner.version>1.0_20230718100517_1e1beb0</tjenestespesifikasjoner.version>
Expand Down Expand Up @@ -445,27 +437,6 @@
<testSourceDirectory>${project.basedir}/src/test/kotlin</testSourceDirectory>
<finalName>${project.artifactId}</finalName>

<pluginManagement>
<plugins>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
<version>3.9.1.2184</version>
</plugin>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<version>0.8.10</version>
<configuration>
<excludes>
<exclude>**/config/FlywayConfig.kt</exclude>
<exclude>**/config/OppdragMQConfig.kt</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</pluginManagement>

<plugins>
<plugin>
<groupId>org.springframework.boot</groupId>
Expand Down