Aria hidden på ikoner som kun er for "syns" skyld (#6624)

navikt · Dec 16, 2024 · de239d9 · de239d9
1 parent 42b23fd
commit de239d9
Show file tree

Hide file tree

Showing 10 changed files with 28 additions and 14 deletions.
diff --git a/...e-saksbehandling-ui/client/src/components/oppgavebenk/components/HandlingerForOppgave.tsx b/...e-saksbehandling-ui/client/src/components/oppgavebenk/components/HandlingerForOppgave.tsx
@@ -79,7 +79,7 @@ export const HandlingerForOppgave = ({
       return (
         <PersonButtonLink
           size="small"
-          icon={<EyeIcon />}
+          icon={<EyeIcon aria-hidden />}
           fnr={fnr || '-'}
           fane={PersonOversiktFane.HENDELSER}
           queryParams={{ referanse: referanse || '-' }}

diff --git a/...te-saksbehandling-ui/client/src/components/oppgavebenk/filtreringAvOppgaver/FilterRad.tsx b/...te-saksbehandling-ui/client/src/components/oppgavebenk/filtreringAvOppgaver/FilterRad.tsx
@@ -132,7 +132,12 @@ export const FilterRad = ({
       </HStack>
 
       <HStack gap="4">
-        <Button onClick={() => hentAlleOppgaver()} size="small" icon={<ArrowCirclepathIcon />} iconPosition="right">
+        <Button
+          onClick={() => hentAlleOppgaver()}
+          size="small"
+          icon={<ArrowCirclepathIcon aria-hidden />}
+          iconPosition="right"
+        >
           Hent oppgaver
         </Button>
         <Button
@@ -144,7 +149,7 @@ export const FilterRad = ({
             setFilter(filter)
           }}
           size="small"
-          icon={<ArrowUndoIcon />}
+          icon={<ArrowUndoIcon aria-hidden />}
           iconPosition="right"
         >
           Tilbakestill filtre

diff --git a/...ksbehandling-ui/client/src/components/oppgavebenk/filtreringAvOppgaver/GosysFilterRad.tsx b/...ksbehandling-ui/client/src/components/oppgavebenk/filtreringAvOppgaver/GosysFilterRad.tsx
@@ -64,7 +64,12 @@ export const GosysFilterRad = ({ hentAlleOppgaver, filter, setFilter, filterFoed
       </HStack>
 
       <HStack gap="4">
-        <Button onClick={() => hentAlleOppgaver()} size="small" icon={<ArrowCirclepathIcon />} iconPosition="right">
+        <Button
+          onClick={() => hentAlleOppgaver()}
+          size="small"
+          icon={<ArrowCirclepathIcon aria-hidden />}
+          iconPosition="right"
+        >
           Hent oppgaver
         </Button>
         <Button
@@ -73,7 +78,7 @@ export const GosysFilterRad = ({ hentAlleOppgaver, filter, setFilter, filterFoed
             setFilter({ enhetFilter: 'visAlle' })
           }}
           size="small"
-          icon={<ArrowUndoIcon />}
+          icon={<ArrowUndoIcon aria-hidden />}
           iconPosition="right"
         >
           Tilbakestill filtre

diff --git a/...tte-saksbehandling-ui/client/src/components/oppgavebenk/oppgaveModal/BrevOppgaveModal.tsx b/...tte-saksbehandling-ui/client/src/components/oppgavebenk/oppgaveModal/BrevOppgaveModal.tsx
@@ -52,7 +52,7 @@ export const BrevOppgaveModal = ({
 
   return (
     <>
-      <Button variant="primary" size="small" icon={<EyeIcon />} onClick={() => setIsOpen(true)}>
+      <Button variant="primary" size="small" icon={<EyeIcon aria-hidden />} onClick={() => setIsOpen(true)}>
         Se oppgave
       </Button>
 

diff --git a/...saksbehandling-ui/client/src/components/oppgavebenk/oppgaveModal/GeneriskOppgaveModal.tsx b/...saksbehandling-ui/client/src/components/oppgavebenk/oppgaveModal/GeneriskOppgaveModal.tsx
@@ -42,7 +42,7 @@ export const GeneriskOppgaveModal = ({
 
   return (
     <>
-      <Button variant="primary" size="small" icon={<EyeIcon />} onClick={() => setOpen(true)}>
+      <Button variant="primary" size="small" icon={<EyeIcon aria-hidden />} onClick={() => setOpen(true)}>
         Se oppgave
       </Button>
 

diff --git a/...sbehandling-ui/client/src/components/oppgavebenk/oppgaveModal/InntektsopplysningModal.tsx b/...sbehandling-ui/client/src/components/oppgavebenk/oppgaveModal/InntektsopplysningModal.tsx
@@ -44,7 +44,7 @@ export const InntektsopplysningModal = ({ oppgave, oppdaterStatus }: Props) => {
 
   return (
     <>
-      <Button variant="primary" size="small" icon={<EyeIcon />} onClick={() => setOpen(true)}>
+      <Button variant="primary" size="small" icon={<EyeIcon aria-hidden />} onClick={() => setOpen(true)}>
         Se oppgave
       </Button>
 

diff --git a/...ing-ui/client/src/components/oppgavebenk/oppgaveModal/TilleggsinformasjonOppgaveModal.tsx b/...ing-ui/client/src/components/oppgavebenk/oppgaveModal/TilleggsinformasjonOppgaveModal.tsx
@@ -65,7 +65,7 @@ export const TilleggsinformasjonOppgaveModal = ({
 
   return (
     <>
-      <Button onClick={() => setIsOpen(true)} size="small" icon={<EyeIcon />}>
+      <Button onClick={() => setIsOpen(true)} size="small" icon={<EyeIcon aria-hidden />}>
         Se oppgave
       </Button>
 

diff --git a/...latte-saksbehandling-ui/client/src/components/oppgavebenk/tildeling/VelgSaksbehandler.tsx b/...latte-saksbehandling-ui/client/src/components/oppgavebenk/tildeling/VelgSaksbehandler.tsx
@@ -265,7 +265,7 @@ export const VelgSaksbehandler = ({ saksbehandlereIEnhet, oppdaterTildeling, opp
         <Dropdown open={openDropdown}>
           <Button
             as={Dropdown.Toggle}
-            icon={valgtSaksbehandler?.ident ? <PersonPencilIcon /> : <PersonPlusIcon />}
+            icon={valgtSaksbehandler?.ident ? <PersonPencilIcon aria-hidden /> : <PersonPlusIcon aria-hidden />}
             iconPosition="left"
             size="small"
             variant="tertiary"
@@ -328,7 +328,7 @@ export const VelgSaksbehandler = ({ saksbehandlereIEnhet, oppdaterTildeling, opp
         </Dropdown>
       ) : (
         <SaksbehandlerNavnHStack gap="2" align="center">
-          <PersonIcon width="1.5rem" height="1.5rem" />
+          <PersonIcon width="1.5rem" height="1.5rem" aria-hidden />
           <Label size="small" textColor="subtle">
             {saksbehandler ? saksbehandler.navn : 'Navn mangler'}
           </Label>

diff --git a/apps/etterlatte-saksbehandling-ui/client/src/shared/components/Sidebar.tsx b/apps/etterlatte-saksbehandling-ui/client/src/shared/components/Sidebar.tsx
@@ -9,7 +9,11 @@ export const Sidebar = ({ children }: { children: ReactNode }) => {
   return (
     <CollapsibleSidebar $collapsed={collapsed}>
       <SidebarTools>
-        <Button variant={collapsed ? 'primary' : 'tertiary'} onClick={() => setCollapsed(!collapsed)}>
+        <Button
+          variant={collapsed ? 'primary' : 'tertiary'}
+          onClick={() => setCollapsed(!collapsed)}
+          aria-label={collapsed ? 'Åpne sidemeny' : 'Lukk sidemeny'}
+        >
           {collapsed ? <ChevronLeftDoubleIcon /> : <ChevronRightDoubleIcon />}
         </Button>
       </SidebarTools>

diff --git a/apps/etterlatte-saksbehandling-ui/client/src/shared/header/ReleaseAlerts.tsx b/apps/etterlatte-saksbehandling-ui/client/src/shared/header/ReleaseAlerts.tsx
@@ -47,9 +47,9 @@ export const ReleaseAlerts = () => {
 
   return (
     <Dropdown onOpenChange={(isOpen) => open(isOpen)}>
-      <InternalHeader.Button as={Dropdown.Toggle}>
+      <InternalHeader.Button as={Dropdown.Toggle} aria-label="Vis varslinger">
         <div style={{ position: 'relative' }}>
-          <BellFillIcon style={{ fontSize: '1.5rem' }} />
+          <BellFillIcon style={{ fontSize: '1.5rem' }} aria-hidden />
           {antallUlest > 0 && <UnreadCircle>{antallUlest}</UnreadCircle>}
         </div>
       </InternalHeader.Button>