Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Årlig Inntektsjustering jobb #6053

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Årlig Inntektsjustering jobb #6053

merged 4 commits into from
Oct 21, 2024

Conversation

Bjodn
Copy link
Contributor

@Bjodn Bjodn commented Oct 21, 2024

  • Endrer eksisterende River tiltenkt varselbrev til å omregne
  • Flytter logikk fra River til behandling
  • Legger på TODOS for mangler som skal utbedres i egne PR

@Bjodn Bjodn marked this pull request as ready for review October 21, 2024 08:06
@Bjodn Bjodn requested a review from a team as a code owner October 21, 2024 08:06
// TODO Legge til en begrunnelse
omregningService.oppdaterKjoering(KjoeringRequest(kjoering, KjoeringStatus.FERDIGSTILT, sakId))
} else if (kanIkkeKjoeresAutomatisk()) {
// TODO Finnes det tilfeller av dette?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg vet ikke om vi har tenkt på "omregning med brev" som en oppgave -- men hvis det f.eks. er det så vil man ikke kunne gjøre en full automatisert behandling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja vi må avklare alle tilfeller hvor vi ikke kan gjøre dette automatisk

@Bjodn Bjodn merged commit 671fa82 into main Oct 21, 2024
@Bjodn Bjodn deleted the inntektsjustering-jobb branch October 21, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants