EY-4669 Fjern alle requires med internfeilexception check #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgesti
approved these changes
Nov 13, 2024
tvsignal
reviewed
Nov 13, 2024
| @@ -11,6 +11,7 @@ fun <T : Any> checkNotNullOrThrowException( | |||
| } | |||
| } | |||
|
|
|||
| // Todo endre til if(value) | |||
There was a problem hiding this comment.
TODO? Er det noe mer å gjøre her da? if (!value) ser jo riktig ut 😄
There was a problem hiding this comment.
Det er riktig men bruken burde vært uten negering, men droppa det pga risiko for feil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tenker at spesialiseringer av feilmeldingene kan komme senere, viktigste er å bli kvitt de standard dårlige feilmeldingene som IllegalArgumentException og IllegalStateException
Har også lagt på beskrivelse mange steder på requires, men ingen tester tester de så ja hvem vet om de er nyttige, foråpentligvis har vi noen tester som sjekker tilstanden om de brukes også,