Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avkorting feil etter varselbrevjobb #6444

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Avkorting feil etter varselbrevjobb #6444

merged 4 commits into from
Nov 25, 2024

Conversation

Bjodn
Copy link
Contributor

@Bjodn Bjodn commented Nov 25, 2024

Varselbrevjobb har en egen metode for å opprette avkorting og har ikke videreført tidligere årsoppgjør som har medført at revurdering tilbake i tid feiler fordi årsoppgjør for tidligere år da mangler

@Bjodn Bjodn marked this pull request as ready for review November 25, 2024 14:32
@Bjodn Bjodn requested a review from a team as a code owner November 25, 2024 14:32
@Bjodn Bjodn changed the title Avkorting feil Avkorting feil etter varselbrevjobb Nov 25, 2024
alleVedtak: List<VedtakSammendragDto>,
): Avkorting {
if (YearMonth.now() > YearMonth.of(2025, 5)) {
logger.warn("AvkortingReparerAarsoppgjoeret.kt har nå med sikkerhet blitt kjørt på alle saker etter regulering og kan fjernes!")
Copy link
Contributor

@andreasbalevik andreasbalevik Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burde denne være en error så vi fanger det opp i Slack?

Copy link
Contributor

@andreasbalevik andreasbalevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bjodn Bjodn merged commit 1f2d4c9 into main Nov 25, 2024
8 checks passed
@Bjodn Bjodn deleted the avkorting-feil branch November 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants