Inntektsjustering legge til inntekt i omregningsflyt #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjodn
force-pushed
the
inntektsjustering-legge-til-inntekt
branch
2 times, most recently
from
45122fa to
eea5b0f
Compare
Bjodn
force-pushed
the
inntektsjustering-legge-til-inntekt
branch
2 times, most recently
from
d0d1a54 to
6dba6c1
Compare
Bjodn
force-pushed
the
inntektsjustering-legge-til-inntekt
branch
from
6dba6c1 to
49c3bd9
Compare
oyvindsh
reviewed
Nov 26, 2024
| } catch (e: JsonMappingException) { | ||
| sikkerLogg.error("Feil under deserialisering", e) | ||
| logger.error("Feil under deserialisering av inntektsjustering (id=${inntektsjustering.id}). Se sikkerlogg for detaljer.") | ||
| throw e | ||
| } catch (e: Exception) { | ||
| logger.error("Uhåndtert feilsituasjon TODO : $", e) | ||
| throw e | ||
| // throw e TODO ta stilling til hvordan feil her skal håndteres... |
There was a problem hiding this comment.
Er ikke denne tryggere å bare beholde som throw e hvis vi ikke har en bedre avklaring?
There was a problem hiding this comment.
Jeg fjernet den mest fordi det hadde køet opp flere meldinger som gjorde at appen havnet i crash loop. Vi bør gjøre det samme som for søknader. Der kastes ikke feilmelding videre men hvis alt er ok så sendes det en melding tilbake når alt er ok.
oyvindsh
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.