Essi endepunkt var feil EY-4277 #6461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebassonav
commented
Nov 27, 2024
| @@ -59,7 +56,7 @@ fun Route.behandlingSakRoutes( | |||
| } | |||
| } | |||
|
|
|||
| route("/${SAKID_CALL_PARAMETER}") { | |||
| route("/{$SAKID_CALL_PARAMETER}") { | |||
There was a problem hiding this comment.
Oi, bra catch. Ser det snek seg med i denne: 9db8521
Her ser vi nok et eksempel på hvorfor 404 er problematisk å bruke for både "url finnes ikke" og "sak finnes ikke"... 🤷♂️
There was a problem hiding this comment.
Ja, det er vanskelig å vite hva som er hva da.
Kanskje endre bruken av GenerellIkkeFunnetException som brukes en del steder?
henrikg
approved these changes
Nov 27, 2024
apps/etterlatte-api/src/test/kotlin/no/nav/etterlatte/samordning/sak/BehandlingSakRoutesTest.kt
Outdated
Show resolved
Hide resolved
| ) | ||
| } | ||
| response.status shouldBe HttpStatusCode.OK | ||
| println(response.bodyAsText()) |
apps/etterlatte-api/src/test/kotlin/no/nav/etterlatte/samordning/sak/BehandlingSakRoutesTest.kt
Outdated
Show resolved
Hide resolved
apps/etterlatte-api/src/test/kotlin/no/nav/etterlatte/samordning/sak/BehandlingSakRoutesTest.kt
Outdated
Show resolved
Hide resolved
Watercolours
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
se EY-4277
se https://logs.adeo.no/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:now-7d%2Fd,to:now))&_a=(columns:!(level,message,envclass,application,pod),dataSource:(dataViewId:'96e648c0-980a-11e9-830a-e17bbd64b4db',type:dataView),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:'96e648c0-980a-11e9-830a-e17bbd64b4db',key:x_correlation_id,negate:!f,params:(query:'7c4e40a8-59da-43e6-b997-c97c4955eaf9'),type:phrase),query:(match_phrase:(x_correlation_id:'7c4e40a8-59da-43e6-b997-c97c4955eaf9')))),hideChart:!f,interval:auto,query:(language:lucene,query:'namespace:etterlatte%20AND%20envclass:p%20AND%20application:%22etterlatte-api%22'),sort:!(!('@timestamp',desc)))