EY-4798 Vis advarsel hvis det er gjeldende unntak i saken #6474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som brevmalen ikke tar høyde for
andreasbalevik
approved these changes
Nov 28, 2024
sebassonav
reviewed
Nov 28, 2024
| import { IAktivitetspliktVurderingNyDto } from '~shared/types/Aktivitetsplikt' | ||
|
|
||
| function loeperUnntakEtterSisteVurdering(vurdering: IAktivitetspliktVurderingNyDto): boolean { | ||
| const nyesteVurdering = [...vurdering.aktivitet] |
There was a problem hiding this comment.
Trenger vi å lage en ny array her egentlig, kan du ikke bare returnere siste element? :D
sebassonav
reviewed
Nov 28, 2024
| import { useAktivitetspliktOppgaveVurdering } from '~components/aktivitetsplikt/OppgaveVurderingRoute' | ||
| import { IAktivitetspliktVurderingNyDto } from '~shared/types/Aktivitetsplikt' | ||
|
|
||
| function loeperUnntakEtterSisteVurdering(vurdering: IAktivitetspliktVurderingNyDto): boolean { |
There was a problem hiding this comment.
Vi kaller vel "vurdering" her både for aktivitet og unntak, så kanskje loeperUnntakEtterSisteAktivitet?
sebassonav
reviewed
Nov 28, 2024
| const nyesteFom = new Date(nyesteVurdering.fom) | ||
|
|
||
| const harUnntakSomLoeper = vurdering.unntak.some((unntak) => !unntak.tom || new Date(unntak.tom) >= nyesteFom) | ||
| return harUnntakSomLoeper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
som brevmalen ikke tar høyde for