Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EY-4808: Bruk angitt flyttedato for innflytting #6559

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

emilps
Copy link
Contributor

@emilps emilps commented Dec 4, 2024

Legger også til gyldighetsdato og ajourholdsdato som brukes i pesys i dag.
Ta gjerne en ekstra titt på Utlandsmapper da mye er lånt fra pesys for at dato skal være lik i begge systemer.

Skjermbilde 2024-12-04 kl  10 34 42

Skjermbilde 2024-12-04 kl  10 34 50

@emilps emilps requested a review from a team as a code owner December 4, 2024 09:39
Copy link
Contributor

@Watercolours Watercolours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kunne med fordel hatt litt bedre tester. Akkurat nå er det ikke mye av logikken her som faktisk blir testet.

val gyldighetstidspunkt: LocalDate? = innflytting?.folkeregistermetadata?.gyldighetstidspunkt?.toLocalDate()
val ajourholdstidspunkt: LocalDate? = innflytting?.folkeregistermetadata?.ajourholdstidspunkt?.toLocalDate()

val innvandretDato =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har vi noe å vise til når det gjelder denne logikken? Kan vi feks skrive en kommentar om at det er hentet fra pesys?

@emilps emilps merged commit 2fa5a22 into main Dec 5, 2024
64 checks passed
@emilps emilps deleted the EY-4808_endre-dato-for-innflytting branch December 5, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants