-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EY-4808: Bruk angitt flyttedato for innflytting #6559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kunne med fordel hatt litt bedre tester. Akkurat nå er det ikke mye av logikken her som faktisk blir testet.
apps/etterlatte-pdltjenester/src/main/kotlin/pdl/mapper/UtlandMapper.kt
Outdated
Show resolved
Hide resolved
...etterlatte-saksbehandling-ui/client/src/components/person/personopplysninger/Innflytting.tsx
Outdated
Show resolved
Hide resolved
val gyldighetstidspunkt: LocalDate? = innflytting?.folkeregistermetadata?.gyldighetstidspunkt?.toLocalDate() | ||
val ajourholdstidspunkt: LocalDate? = innflytting?.folkeregistermetadata?.ajourholdstidspunkt?.toLocalDate() | ||
|
||
val innvandretDato = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Har vi noe å vise til når det gjelder denne logikken? Kan vi feks skrive en kommentar om at det er hentet fra pesys?
apps/etterlatte-pdltjenester/src/main/kotlin/pdl/mapper/UtlandMapper.kt
Outdated
Show resolved
Hide resolved
apps/etterlatte-pdltjenester/src/main/kotlin/pdl/mapper/UtlandMapper.kt
Outdated
Show resolved
Hide resolved
apps/etterlatte-pdltjenester/src/main/kotlin/pdl/mapper/UtlandMapper.kt
Outdated
Show resolved
Hide resolved
…/personopplysninger/Innflytting.tsx Co-authored-by: Henrik Gundersen <[email protected]>
Legger også til gyldighetsdato og ajourholdsdato som brukes i pesys i dag.
Ta gjerne en ekstra titt på Utlandsmapper da mye er lånt fra pesys for at dato skal være lik i begge systemer.