EY-4842: Opprettet service for utsending av brev #6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watercolours
approved these changes
Dec 12, 2024
Comment on lines
+55
to
+59
| // TODO burde dette heller håndteres fra en tabell slik at det kan oppdateres uten å endre koden? | ||
| companion object { | ||
| val ANTALL_SAKER: Long = 1 | ||
| val EKSKLUDERTE_SAKER: List<Long> = emptyList() | ||
| } |
There was a problem hiding this comment.
Alternativ nais config?
There was a problem hiding this comment.
trenger vi ekskluderte saker egentlig? hvis ikke bare å droppe det vel er bare unødvendig kompleksitet
| val sisteIdent = | ||
| when (sisteIdentifikatorPdl) { | ||
| is PdlIdentifikator.FolkeregisterIdent -> sisteIdentifikatorPdl.folkeregisterident.value | ||
| is PdlIdentifikator.Npid -> sisteIdentifikatorPdl.npid.ident |
There was a problem hiding this comment.
Flyten vil vel generelt ikke fungere dersom ident er NPID? 🤔
sebassonav
reviewed
Dec 12, 2024
| } | ||
|
|
||
| fun hentKlareJobber( | ||
| antallSaker: Long, |
There was a problem hiding this comment.
todo: mangler limit i spørringen her
sebassonav
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.