Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAGSYSTEM-360070 Støtte oppdatering av ident UTEN hendelse #6604

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

Watercolours
Copy link
Contributor

@Watercolours Watercolours commented Dec 12, 2024

  • Reducer for å ha en state med "valgt person". Unngår unødvendig mye prop drilling
  • Advarsel hvis allerede oppdatert ident
  • Muliggjør oppdatering uten hendelse

Viser knapp for endring på saksoversikt

Viktig i tilfeller hvor vi ikke har fått en hendelse. Dette kan f.eks. skje dersom bruker søker med DNR, etter de har fått FNR.
Screenshot 2024-12-12 at 12 17 11

Skjuler knapp dersom en sak allerede har oppdatert ident

Screenshot 2024-12-12 at 12 17 04

@Watercolours Watercolours requested a review from a team as a code owner December 12, 2024 11:20
Copy link
Contributor

@andreasbalevik andreasbalevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ville kanskje slengt på et ikon for oppdater ident knappen? ArrowCirclepathIcon f.eks

@Watercolours Watercolours merged commit 13372aa into main Dec 13, 2024
7 checks passed
@Watercolours Watercolours deleted the FAGSYSTEM-360070_oppdatere-ident-uten-hendelse branch December 13, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants