Bump Kotlin til 2.0.21 og bruk Java 21 #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
commented
Dec 12, 2024
Comment on lines
-6
to
-9
| val githubPassword: String by project | ||
|
|
||
| // Dependencies | ||
| val micrometerVersion: String by project |
There was a problem hiding this comment.
Flytter disse der de blir brukt, og sorterer alfabetisk.
bjerga
commented
Dec 12, 2024
Comment on lines
-153
to
+140
| implementation("no.nav.teamdokumenthandtering:teamdokumenthandtering-avro-schemas:$joarkHendelseVersion") | ||
| implementation("org.jetbrains.kotlin:$jetbrainsStdLib") | ||
| implementation("com.fasterxml.jackson.datatype:jackson-datatype-jdk8:$jacksonVersion") | ||
| implementation("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:$jacksonVersion") |
There was a problem hiding this comment.
Sorterer alfabetisk.
bjerga
commented
Dec 12, 2024
| kotlinterVersion=4.3.0 | ||
| versionsVersion=0.50.0 | ||
|
|
||
| # Dependency versions | ||
| micrometerVersion=1.8.3 |
There was a problem hiding this comment.
Sorterer alfabetisk.
|
Testet OK. |
magnusae
approved these changes
Dec 13, 2024
| - name: Setup Java environment | ||
| uses: actions/setup-java@v1 | ||
| with: | ||
| java-version: '17' | ||
| java-version: 21 |
There was a problem hiding this comment.
Tipper fnuttene er tatt vekk med vilje?
There was a problem hiding this comment.
Ja, bare for å gjøre det likt. De har ingen hensikt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.