Bytter til distroless image og endrer til docker-build-push for å generere sbom ved bygging #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
reviewed
Jan 9, 2025
Comment on lines
+3
to
+6
| ENV JAVA_OPTS='-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp' | ||
| ENV LANG='nb_NO.UTF-8' LANGUAGE='nb_NO:nb' LC_ALL='nb:NO.UTF-8' TZ="Europe/Oslo" | ||
| ENTRYPOINT ["java", "-jar", "/app.jar"] | ||
| EXPOSE 8080 |
There was a problem hiding this comment.
Er det dokumentert noe sted at vi må bruke disse innstillingene?
There was a problem hiding this comment.
Vi *må nok ikke - men en sterk oppfordring / anbefaling fra app sec-teamet om å bruke distroless hvertfall.
heapdumpOnOutOfMemoryError er bare min egen kjepphest, den synes jeg er kjekk å ha på
Og det er dokumentert noe her;
https://sikkerhet.nav.no/docs/sikker-utvikling/containere#distroless
bjerga
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.