Improve checking ubehandlet #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersrognstad
force-pushed
the
IS-improve-isUbehandlet-check
branch
from
50a2eca to
3f54de0
Compare
eirikdahlen
approved these changes
Oct 12, 2023
| personOversiktStatus.oppfolgingsplanLPSBistandUbehandlet, | ||
| aktivitetskravActive: personOversiktStatus.aktivitetskravActive, | ||
| }; | ||
| return isUbehandlet(ubehandletStatus); |
There was a problem hiding this comment.
Så hvis man husker på å legge den til i PersonOversiktUbehandletStatusDTO, så burde det gi feilmelding her, da?
There was a problem hiding this comment.
Stemmer! Og den DTOen vil man vel typisk starte med å utvide når man har lagt på et nytt flagg/oppgave i backend, så tenker det blir en forbedring.
JMLindseth
approved these changes
Oct 13, 2023
geir-waagboe
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hva har blitt lagt til✨🌈
Prøver å forbedre logikken for å sjekke isUbehandlet i frontend så man slipper å huske å utvide if-en ved nytt filter/oppgave (forhåpentligvis kan vi kvitte oss med dette i frontend og bare sjekke i backend på sikt).