Feature/dolly frontend react hook form migration #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#deploy-test-frontend
…ration # Conflicts: # apps/dolly-frontend/src/main/js/package-lock.json
#deploy-test-frontend
#deploy-test-frontend
En del mer refaktorering på Formik -> React-hook-forms
…ration # Conflicts: # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/adresser/bostedsadresse/Bostedsadresse.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/adresser/kontaktadresse/Kontaktadresse.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/adresser/oppholdsadresse/Oppholdsadresse.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/familierelasjoner/forelderBarnRelasjon/BarnRelasjon.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/familierelasjoner/forelderBarnRelasjon/ForelderBarnRelasjon.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/familierelasjoner/sivilstand/Sivilstand.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/foedsel/Foedsel.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/navn/Navn.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/nyIdent/nyIdent.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/persondetaljerSamlet/PersondetaljerSamlet.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/visning/visningRedigerbar/VisningRedigerbar.tsx
…tt en del arbeid som gjenstår for å få det til å fungere
…mplementasjon #deploy-test-dolly-backend
…oen hooks for å hente Redux state direkte istendenfor å sende de ned gjennom en haug av komponenter
…anisasjoner Fikset bugs med TextInput komponent som ikke viste rød border ved feil Gjort feilmeldinger mer robust ved å legge alle feil i form for å hente ut der de trengs med hook
…g of refaktorering
…ration # Conflicts: # apps/dolly-frontend/src/main/js/src/components/bestillingsveileder/stegVelger/steg/steg1/paneler/Pensjon.tsx # apps/dolly-frontend/src/main/js/src/components/fagsystem/alderspensjon/form/Form.tsx # apps/dolly-frontend/src/main/js/src/pages/testnorgePage/search/partials/Identer.tsx
…sjoner form ferdigstilt og gjort en del oppdatering og refaktorering
…sjoner form ferdigstilt og gjort en del oppdatering og refaktorering
…ration # Conflicts: # apps/dolly-frontend/src/main/js/src/pages/dollySoek/ResultatVisning.tsx # apps/dolly-frontend/src/main/js/src/pages/dollySoek/SoekForm.tsx
…970 under form input #deploy-test-frontend
#deploy-test-frontend
#deploy-test-frontend
#deploy-test-frontend
#deploy-test-frontend
#deploy-test-frontend
#deploy-test-frontend
…ration # Conflicts: # apps/dolly-frontend/src/main/js/package-lock.json
#deploy-test-frontend
… komponenter #deploy-test-frontend
#deploy-test-frontend
#deploy-test-frontend
…ammeverk #deploy-test-frontend
betsytraran
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Fantastisk bra jobb! 🤩
Godkjent med følgende forbehold:
- Dra inn master og sjekk at TpsMessaging er fjernet fra bestillinger med sikkerhetstiltak.
- Feilene vi tok muntlig i dag er rettet.
- Feilene som er kommentert på PRen er rettet, og har ikke introdusert nye feil.
😎
#deploy-test-frontend
…ration # Conflicts: # apps/dolly-frontend/src/main/js/src/components/fagsystem/pdlf/form/partials/sikkerhetstiltak/Sikkerhetstiltak.tsx
#deploy-test-frontend
#deploy-test-frontend
#deploy-test-frontend
#deploy-test-frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.