Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change/sonar-jacoco-cleanup #3400

Merged
merged 2 commits into from
Jan 26, 2024
Merged

change/sonar-jacoco-cleanup #3400

merged 2 commits into from
Jan 26, 2024

Conversation

rfc3092
Copy link
Contributor

@rfc3092 rfc3092 commented Jan 26, 2024

Endringer for Sonar:

Feil:
Finner ikke output fra JaCoCo, ref.:

No coverage report can be found with sonar.coverage.jacoco.xmlReportPaths='property(org.gradle.api.file.Directory,fixed(class org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedDirectory,**your-source-path-here**))/reports/jacoco/test/jacocoTestReport.xml'. Using default locations: target/site/jacoco/jacoco.xml,target/site/jacoco-it/jacoco.xml,build/reports/jacoco/test/jacocoTestReport.xml

Løsning:
Nye Sonar finner tilsynelatende default output fra JaCoCo automagisk.

Endring:
Cleanup, dvs. fjerner eksplisitt config for JaCoCo output og Sonar input.

Dokumentasjon:
https://docs.sonarsource.com/sonarcloud/advanced-setup/ci-based-analysis/sonarscanner-for-gradle/#additional-defaults-when-jacoco-plugin-is-applied

Disclaimer:
Ikke manuelt testet på alle 90+ builds, men følger opp som del av annet arbeid på workflows.

@rfc3092 rfc3092 marked this pull request as ready for review January 26, 2024 10:05
@rfc3092 rfc3092 requested a review from a team as a code owner January 26, 2024 10:05
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@rfc3092 rfc3092 merged commit 1ed07b2 into master Jan 26, 2024
521 checks passed
@rfc3092 rfc3092 deleted the change/sonar-jacoco-cleanup branch January 26, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants