Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/java-conventions-plugin #3503

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

rfc3092
Copy link
Contributor

@rfc3092 rfc3092 commented Jun 4, 2024

Laget en helt basic convention plugin som setter en del antatt felles ting for å unngå boilerplate. Ref. endringer i budpro-service sin build.properties.

Foreløpig kun satt på budpro-service for testing inntil vi lander på om 1) dette er noe vi vil ha, 3) hva vi vil ha satt i felles plugin. Også trivielt å legge til flere plugins etterhvert, og ikke nødvendigvis bare skrevet i Groovy (Java, Kotlin).

Mulig mer kan gjøres "felles" også mtp. dependencies, eller vi kan velge å helt utelukke dependencies fra plugin. Argumenter finnes for begge.

@rfc3092 rfc3092 marked this pull request as ready for review June 4, 2024 19:59
@rfc3092 rfc3092 requested a review from a team as a code owner June 4, 2024 19:59
@rfc3092
Copy link
Contributor Author

rfc3092 commented Jun 5, 2024

Forenkle Gradle builds

Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette blir kult å få på plass 😄

@rfc3092 rfc3092 merged commit 3e4751e into master Jun 5, 2024
10 checks passed
@rfc3092 rfc3092 deleted the feature/java-conventions-plugin branch June 5, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants