Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/inntekt altinn joark #3508

Merged
merged 11 commits into from
Jun 10, 2024
Merged

Bugfix/inntekt altinn joark #3508

merged 11 commits into from
Jun 10, 2024

Conversation

stigus
Copy link
Contributor

@stigus stigus commented Jun 10, 2024

No description provided.

stigus added 10 commits June 5, 2024 09:47
#deploy-inntektsmelding-generator-service
… xsd for å kunne bruke jakarta bibliotek istedenfor deprecated javax
… xsd for å kunne bruke jakarta bibliotek istedenfor deprecated javax
…tek istedenfor deprecated javax

#deploy-inntektsmelding-generator-service
…tek istedenfor deprecated javax

#deploy-inntektsmelding-generator-service
…tek istedenfor deprecated javax

#deploy-inntektsmelding-generator-service
…tek istedenfor deprecated javax

#deploy-inntektsmelding-generator-service
#deploy-inntektsmelding-generator-service
#deploy-inntektsmelding-generator-service
@stigus stigus marked this pull request as ready for review June 10, 2024 09:43
@stigus stigus requested a review from a team as a code owner June 10, 2024 09:43
Copy link
Contributor

@rfc3092 rfc3092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Hadde vært fint med en test eller to på InntektsmeldingController.

@krharum krharum self-requested a review June 10, 2024 10:52
Copy link
Contributor

@krharum krharum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se kommentarer 👍

@@ -0,0 +1,47 @@
package no.nav.registre.inntektsmeldinggeneratorservice.v20181211.provider.v2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Husk oppdatering av pakkenavn for test også

…k noe sted og refaktorering blir tidkrevende

#deploy-inntektsmelding-generator-service
@stigus stigus merged commit 6f44e2d into master Jun 10, 2024
7 of 8 checks passed
@stigus stigus deleted the bugfix/inntekt-altinn-joark branch June 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants