feature/java-conventions-plugin-2 #3511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apps/budpro-service/build.gradle
… gjennom plugin).
…is gjennom plugin).
…(gratis gjennom plugin).
…ratis gjennom plugin).
krharum
approved these changes
Jun 19, 2024
# Conflicts: # .github/workflows/app.dolly-backend.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bruker 3 convention plugins, for apps, libs og proxies. Har også en "intern" plugin for Sonar, mer om det nedenfor.
Det er tatt et bevisst valg på å holde dolly-[apps|libs|proxies] separate i stor grad, dvs. at noe dupliseres her. Tanken er a) å holde bruken av en plugin så enkel som mulig, b) ikke avskrekke noen fra å modifisere en plugin, og c) unngå problemer med at "interne" plugins må dra inn unødvendige egne plugins bare for å kunne sette config. F.eks. vil en "intern" plugin som brukes av både apps og libs måtte dra inn plugin "java", men libs bruker ikke "java" men "java-libs".
Det er heller ikke tanken at dependencies skal styres av konvensjoner, annet enn der det gir litt mening (Lombok, noe Spring-rammeverk for testing, krav fra NAIS mtp. logging/metrics etc. - altså dependencies som helt klart er listefyll). Det kan jo sikkert diskuteres på sikt.
Også verdt å merke seg at vi ikke kan lage en version catalog i Gradle vha. plugins. #hjertesukk