-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AFP offentlig fields to PensjonData #3623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new inner class `AfpOffentlig` with relevant fields and methods to handle AFP offentlig data. This includes new constraints using `@Min` and `@Max` annotations, and additional enumerations for `StatusAfp`. These changes enhance the model to support detailed information about AFP offentlig.
…proxy Enhanced the proxy application to support routing for AFP Offentlig mock endpoints. Refactored configuration to accommodate dynamic environment-specific URLs and namespaces. Added new server properties classes for better code organization and maintainability.
Introduced new commands and mappings to handle "AfpOffentlig" requests in PensjonforvalterConsumer. Extended status mapping and data domain to include AfpOffentlig.
#deploy-pensjon-testdata-proxy
@deploy-pensjon-testdata-proxy Introduce a new `application-prod.yml` for production OAuth2 setup. Simplify LocalVaultConfig by removing redundant token checks and adding `@NonNull` annotations.
#deploy-pensjon-testdata-proxy Updated the Pensjon Testdata Facade and AFP Offentlig URLs to new environments. Modified corresponding YAML configuration files to align with the new URL settings and namespaces. Added missing ServerProperties for Pensjon Testdata Facade in the Consumers configuration.
Changed the URL parameter from 'fnr' to 'ident' in `SletteAfpOffentligCommand` and updated the response handling in `LagreAfpOffentligCommand`. This ensures consistent usage of the identifier field across requests and responses.
#deploy-pensjon-testdata-proxy Adjusted the HTTP client response-timeout from 1200s to 10s and enabled wiretap for both the client and server to assist in debugging. Additionally, configured logging levels for better traceability within Spring Cloud Gateway components.
#deploy-pensjon-testdata-proxy The afp-offentlig mock service has been removed from the application-dev.yml configuration. The service URL and cluster information have been updated in the application.yml file to reflect the new environment settings.
#deploy-test-dolly-backend #deploy-pensjon-testdata-proxy Changed cluster configuration from dev-fss to dev-gcp for specific applications in the config file. Modified logging messages and switched the HTTP method from POST to PUT for storing AFP-Offentlig data in the relevant Java command class.
#deploy-test-dolly-backend Corrected the PEN_AFP_OFFENTLIG constant to include a trailing '#'. This ensures consistent formatting with other similar constants and may prevent potential issues during data processing.
stigus
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new inner class
AfpOffentlig
with relevant fields and methods to handle AFP offentlig data. This includes new constraints using@Min
and@Max
annotations, and additional enumerations forStatusAfp
. These changes enhance the model to support detailed information about AFP offentlig.