Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historikk for personstatus #3636

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Sep 26, 2024

…t-pdl-forvalter

Refactored the method to streamline the person status handling logic, ensuring statuses are set accurately based on the current context. Added a new method isNotChanged for reflection-based change detection, and enhanced the setGyldigTilOgMed logic to correctly set end validity dates. Removed redundant check for adding new FolkeregisterPersonstatusDTO for NPID type.

…t-pdl-forvalter

Refactored the method to streamline the person status handling logic, ensuring statuses are set accurately based on the current context. Added a new method `isNotChanged` for reflection-based change detection, and enhanced the `setGyldigTilOgMed` logic to correctly set end validity dates. Removed redundant check for adding new `FolkeregisterPersonstatusDTO` for NPID type.
#deploy-test-pdl-forvalter

Added handling for `FolkeregisterPersonstatus` and its validation dates in `SwopIdentsService`, `PersonArtifactService`, and `FolkeregisterPersonstatusService`. Enhanced `FolkeregisterPersonstatusService` to set `GyldigFraOgMed` based on derived dates from residence address or birth date.
Corrected minor indentation issue in the getBoadresseGyldigFraDato method signature. This addresses code formatting consistency for improved readability.
@krharum krharum marked this pull request as ready for review September 27, 2024 05:43
@krharum krharum requested a review from a team as a code owner September 27, 2024 05:43
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser flott ut 😄

@krharum krharum merged commit c866247 into master Oct 1, 2024
347 of 348 checks passed
@krharum krharum deleted the feature/historikk-for-personstatus branch October 1, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants