change/from_vault_to_secretmanager #3654
Open
+1,807
−2,799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d given proper login with gcloud for current project.
- Normalizes config file name to application-test.yml.
…g timestamp fields.
…ev since it is apparently no longer in use.
krharum
reviewed
Nov 22, 2024
# Conflicts: # examples/reactive-rest-example/README.md # examples/reactive-rest-example/build.gradle # examples/reactive-rest-example/settings.gradle # examples/reactive-rest-example/src/main/resources/application-local.yml # examples/reactive-rest-example/src/main/resources/application.yml
- Removed unnecessary hibernate.dialect config.
- H2 didn't work with current migrations - switched to local PSQL.
… IBM MQ is used instead. - Reenabling test. - Config renamed from .yaml to yml.
- Updated README.md in /apps.
…n local profile anyway).
- Simplified the remaining 3 API usages of VaultUtils.
1 similar comment
# Conflicts: # apps/sykemelding-api/src/main/java/no/nav/registre/testnorge/sykemelding/config/LocalVaultConfig.java # apps/sykemelding-api/src/main/resources/application.yml # apps/synt-sykemelding-api/src/main/java/no/nav/testnav/apps/syntsykemeldingapi/config/LocalVaultConfig.java # apps/synt-sykemelding-api/src/main/resources/application-dev.yml # apps/synt-sykemelding-api/src/main/resources/application.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erstatter bruk av Vault med GCP Secret Manager.
Gjenværende i
/appsmed Vault:Felles for disse er at de deployer til dev-fss og har en onprem PSQL. Ingenting trenger lenger Vault for å kjøre lokalt.