Bugfix/auth header log fix #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#deploy-proxy-pensjon
#deploy-proxy-pensjon
krharum
approved these changes
Nov 22, 2024
| var replacement = match.substring(0, 6) + "xxxxx"; | ||
| matcher.appendReplacement(result, replacement); | ||
| message = identNummer.matcher(message).replaceAll(match -> { | ||
| if (match.group().charAt(2) == '0' || match.group().charAt(2) == '1') { |
There was a problem hiding this comment.
Strengt tatt vil if (match.group().charAt(2) < '4') være bedre da det også fanger opp NPID som har +2 på måned i prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
TestnavLogbackEncoderclass in thereactive-corelibrary to improve the redaction of sensitive information in log messages. The most important changes include the addition of a new pattern to identify bearer tokens and the refactoring of theformatMessagemethod to use the new patterns for redaction.Improvements to sensitive information redaction:
libs/reactive-core/src/main/java/no/nav/testnav/libs/reactivecore/logging/TestnavLogbackEncoder.java: Added a newPatternnamedbearerto identify bearer tokens.libs/reactive-core/src/main/java/no/nav/testnav/libs/reactivecore/logging/TestnavLogbackEncoder.java: Refactored theformatMessagemethod to use theidentNummerpattern for redacting identification numbers and thebearerpattern for redacting bearer tokens.