Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of
Sivilstand
data in thedolly-backend
andpdl-forvalter
modules. The most important changes involve adding logging, refining date handling in mapping strategies, and ensuring list modifiability in theSivilstandService
.Improvements in logging and data handling:
apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/pensjonforvalter/PensjonforvalterConsumer.java
: Added logging forlagreSamboer
method to log thepensjonSamboerRequest
when creating a new cohabitation.Refinements in mapping strategy:
apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/pensjonforvalter/mapper/PensjonSamboerMappingStrategy.java
: Improved date handling by introducing a variable fordatoTom
and refining the filtering logic to ensure dates are afterdatoTom
. [1] [2]apps/dolly-backend/src/test/java/no/nav/dolly/bestilling/pensjonforvalter/mapper/PensjonSamboerMappingStrategyTest.java
: Added new test cases to cover multipleSivilstand
scenarios and ensure proper mapping. [1] [2] [3]Ensuring list modifiability:
apps/pdl-forvalter/src/main/java/no/nav/pdl/forvalter/service/SivilstandService.java
: Ensured that theSivilstand
list is modifiable by converting it to aLinkedList
if necessary before adding new elements.