Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/missing_azure_app_client #3689

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

rfc3092
Copy link
Contributor

@rfc3092 rfc3092 commented Dec 9, 2024

Erstatter #3687 med en ny tilnærming:

  • AzureNavClientCredential beholdes urørt, men vi endrer format i SPeL for å angi at verdi hentes fra environment.
  • I local profile overstyres AZURE_APP_CLIENT_ID og AZURE_APP_CLIENT_SECRET med verdi fra Secret Manager.

Noe housekeeping, fordi det tæret på psyken når man skal gå gjennom mye config:

  • .yaml er nå .yml.
  • Spring profile dev er nå local - med mindre det er snakk om en faktisk dev-profil dvs. til testmiljø.

- Moved relevant Spring profiles from "dev" to "local".
- Removed unused Logback config for profile "dev" in budpro-service.
- Overriding AZURE_APP_CLIENT_[ID|SECRET] for all "local" profile configs.
@rfc3092 rfc3092 marked this pull request as ready for review December 9, 2024 16:52
@rfc3092 rfc3092 requested a review from a team as a code owner December 9, 2024 16:52
@rfc3092
Copy link
Contributor Author

rfc3092 commented Dec 9, 2024

Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supert å få dette forbedret og likt overalt 😎

# Conflicts:
#	apps/sykemelding-api/src/main/resources/application-local.yml
@rfc3092 rfc3092 merged commit cc262c9 into master Dec 11, 2024
233 checks passed
@rfc3092 rfc3092 deleted the bugfix/missing_azure_app_client branch December 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants