Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/valideringsendepunkt #3691

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Bugfix/valideringsendepunkt #3691

merged 5 commits into from
Dec 10, 2024

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Dec 10, 2024

No description provided.

krharum and others added 3 commits December 10, 2024 11:28
Introduce the KontaktMedPasientDTO class to capture patient contact details such as contact date and reasons for no contact. This addition allows for enhanced tracking of patient interaction in the sykemelding domain.
#deploy-test-sykemelding-api

This update introduces a new class for handling KontaktMedPasient data, enriching the sykemelding model with contact information details. The changes ensure that KontaktMedPasient details are correctly included in the mapping strategy and are validated through updated test cases.
@krharum krharum marked this pull request as ready for review December 10, 2024 11:28
@krharum krharum requested a review from a team as a code owner December 10, 2024 11:28
#deploy-test-sykemelding-api

This commit introduces a new test case to verify the correct handling of null values for KontaktDato in the Sykemelding mapping logic. Additionally, it refactors the KontaktMedPasient constructor by removing the redundant start date parameter, streamlining object creation. These changes enhance the reliability and clarity of the codebase with regard to contact date management in health certificates.
…ding-api

Ensure that the KontaktMedPasient constructor checks for a null DTO before creating a new XMLHelseOpplysningerArbeidsuforhet.KontaktMedPasient instance. This change prevents potential null pointer exceptions and improves the robustness of the code.
Copy link
Contributor

@stigus stigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flott 😄

@krharum krharum merged commit ab7d148 into master Dec 10, 2024
6 checks passed
@krharum krharum deleted the bugfix/valideringsendepunkt branch December 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants