Sikkerhetstiltak additional info [Waiting for Kari's feedback for visual representation] #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slovrid
reviewed
Feb 16, 2023
slovrid
reviewed
Feb 16, 2023
src/utils/dato-utils.ts
Outdated
| if (tiltakBeskrivelse && tiltakBeskrivelse.length > 0) { | ||
| tittelVerdi += ': ' + tiltakBeskrivelse; | ||
| } | ||
| if (tiltakFra && tiltakTil) { |
There was a problem hiding this comment.
Why are we checking tiltakFra when only using tiltakTil?
There was a problem hiding this comment.
first idea was to show also tiltakFra...I will remove it
slovrid
reviewed
Feb 16, 2023
slovrid
approved these changes
Feb 16, 2023
Co-authored-by: Sondre Ovrid <[email protected]>
Co-authored-by: Sondre Ovrid <[email protected]>
dragutin-nav
commented
Feb 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Waiting for Kari to check visual representation for sikkerhetstiltak |
dragutin-nav
changed the title
|
@dragutin-nav Will you check out the code smells too? Especially the critical |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.