Log: Switch to fmt::text_style for coloring #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would be okay with doing that. |
|
Sorry, I should've explained what the issue is. Log currently uses ANSI escape codes to set output line colour, but doesn't close with a reset code. This results in all subsequent terminal output being painted in whatever the last colour was set, even after the process has quit. This PR fixes that, and also makes it obvious what colours are used. Pushed the change, should be ready to go. |
GranMinigun
force-pushed
the
log-coloring
branch
from
117f41b to
62d376a
Compare
Ah, no worries. I got what this is doing. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got somewhat tired of all-magenta terminal.
Before you merge - what do you think of dropping colouring of info messages (instead of painting them white)?