WIP: json session store #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's always better to have a human-readable JSON file than an unreadable DAT one containing bytes. You can see what the session file contains, what it is all about. Also, it prevents the file from getting corrupted. Happened to me a few times in the past using FileSessionStore, had to delete the session file and reconnect/auth. And it's just way better in general for storing data. For example, I currently store a lot of sessions in a SQL database, and doing it with bytes would have been a pain. JSON session file is just better in general.
aarani
suggested changes
Oct 13, 2020
| @@ -160,17 +239,17 @@ public static Session FromBytes(byte[] buffer, ISessionStore store, string sessi | |||
|
|
|||
| var isAuthExsist = reader.ReadInt32() == 1; | |||
| int sessionExpires = 0; | |||
| TLUser TLUser = null; | |||
| int userId = default; | |||
| if (isAuthExsist) | |||
There was a problem hiding this comment.
lol that typo is not in my commit :P
| if (isAuthExsist) | ||
| { | ||
| sessionExpires = reader.ReadInt32(); | ||
| TLUser = (TLUser)ObjectUtils.DeserializeObject(reader); | ||
| userId = (int)ObjectUtils.DeserializeObject (reader); |
| { | ||
| writer.Write(1); | ||
| writer.Write(SessionExpires); | ||
| ObjectUtils.SerializeObject(TLUser, writer); | ||
| ObjectUtils.SerializeObject (UserId, writer); |
| } | ||
| public bool AuthenticatedSuccessfully { |
There was a problem hiding this comment.
Technically we don't have to save UserId at all because we can just run GetSelfUser and If we're not authenticated we get an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.