Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deleting sessions #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Muaath5
Copy link

@Muaath5 Muaath5 commented May 17, 2021

Add Delete method to session.

This method is useful when logging out.

@knocte
Copy link
Member

knocte commented May 17, 2021

@aarani please review

string sessionFileName = $"{session.SessionUserId}.dat";
var sessionPath = basePath == null ? sessionFileName :
Path.Combine (basePath.FullName, sessionFileName);
File.Delete(sessionFileName);
Copy link

@aarani aarani May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if the file exists first.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll commit another

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aarani Should I throw Exception when not exists?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, just ignore the command if it doesn't

Copy link
Author

@Muaath5 Muaath5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aarani Is it good now?

@knocte
Copy link
Member

knocte commented May 18, 2021

Looks good, we will merge it after PR41 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants