-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0.1 updates #2
base: master
Are you sure you want to change the base?
Conversation
Added 5.0.1 specific build and installation steps.
Please do not bundle binary files (like |
Sure thing, thanks! |
@elastickent We're not using What is the best practise here? (We're not javascript super-pro, sorry :/ ) |
Thank you for updating the screenshot, but can you please answer the question in my previous comment? Thank you. |
Also, maybe unrelated, in the gif you added, the refresh time is different than the timing window (10 seconds vs 1 minute). Kibana is going to fetch events from last minute and do it every 10 seconds, so you are going to see the same events many time (and more than it should). I am not sure this was clearly explained in the readme file. |
Great question. Kibana's plugin interface is not stable release to release, so separate versions seem to make the most sense to me. Thanks for catching the timing issue in the gif. |
I don't think that we can afford to maintain several versions, especially for Kibana versions that we're not using. What about a try-catch? |
try catch wont work in the json file. however, what I suggest is maintaining different braches and then update the readme instruction to specify the branch version when they do the git clone |
Hi Anyone can help me? in package.json I changed the version for 5.4.0. |
Same problem: |
Visualize: Cannot read property 'group' of undefined Disable: Place markers off grid (use geocentroid) in Coordinates and the error goes away. |
Can confirm that this works on 5.2.3 as I have it running in a production environment. |
Updated version and new paths to dependencies. Also updated the readme to include 5.0.1 build and install steps.