Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to Master merge, release v5.33.0 #167

Merged
merged 16 commits into from
Oct 8, 2024
Merged

Develop to Master merge, release v5.33.0 #167

merged 16 commits into from
Oct 8, 2024

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Oct 8, 2024

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.34%. Comparing base (09ca679) to head (ebf586c).

Files with missing lines Patch % Lines
controllers/users_controller.rb 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   73.39%   73.34%   -0.05%     
==========================================
  Files          53       53              
  Lines        2954     2953       -1     
==========================================
- Hits         2168     2166       -2     
- Misses        786      787       +1     
Flag Coverage Δ
unittests 73.34% <88.88%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr marked this pull request as ready for review October 8, 2024 02:40
@alexskr alexskr merged commit 73a23db into master Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants