Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Centralize mapping creation #157

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Sep 14, 2022

Prerequisite

Changes

  • Unify how the mapping was created, in a unique method called create_mapping(mapping_hash:, user_creator:, check_exist: false) isolated in a module.
  • add a validation to the RestBackupMapping model to enforce that class_urns (the mapped classes) contain at least two classes.

…o pr/feature/add-mappings-source-object-attributes
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #157 (7868dd6) into master (b5057b4) will increase coverage by 0.30%.
The diff coverage is 85.82%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   80.75%   81.05%   +0.30%     
==========================================
  Files          63       66       +3     
  Lines        4848     4952     +104     
==========================================
+ Hits         3915     4014      +99     
- Misses        933      938       +5     
Flag Coverage Δ
unittests 81.05% <85.82%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ontologies_linked_data/mappings/mappings.rb 81.14% <81.18%> (-0.81%) ⬇️
...s_linked_data/concerns/mappings/mapping_creator.rb 94.68% <94.68%> (ø)
.../ontologies_linked_data/models/mappings/mapping.rb 98.03% <96.96%> (ø)
lib/ontologies_linked_data.rb 100.00% <100.00%> (ø)
...linked_data/concerns/mappings/mapping_bulk_load.rb 100.00% <100.00%> (ø)
...ology_submissions/submission_metadata_extractor.rb 100.00% <100.00%> (ø)
...tologies_linked_data/models/ontology_submission.rb 78.63% <100.00%> (-0.12%) ⬇️
lib/ontologies_linked_data/parser/owlapi.rb 80.58% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syphax-bouazzouni syphax-bouazzouni force-pushed the pr/refactor/centralize-mapping-creation branch from aa72900 to 7b67f9d Compare September 14, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant