forked from ontoportal/ontologies_linked_data
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Centralize mapping creation #157
Open
syphax-bouazzouni
wants to merge
34
commits into
ncbo:master
Choose a base branch
from
ontoportal-lirmm:pr/refactor/centralize-mapping-creation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor: Centralize mapping creation #157
syphax-bouazzouni
wants to merge
34
commits into
ncbo:master
from
ontoportal-lirmm:pr/refactor/centralize-mapping-creation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o pr/feature/add-mappings-source-object-attributes
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 80.75% 81.05% +0.30%
==========================================
Files 63 66 +3
Lines 4848 4952 +104
==========================================
+ Hits 3915 4014 +99
- Misses 933 938 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
syphax-bouazzouni
force-pushed
the
pr/refactor/centralize-mapping-creation
branch
from
September 14, 2022 12:39
aa72900
to
7b67f9d
Compare
9 tasks
57 tasks
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite
Changes
create_mapping(mapping_hash:, user_creator:, check_exist: false)
isolated in a module.RestBackupMapping
model to enforce thatclass_urns
(the mapped classes) contain at least two classes.