Fix packed decimal left shift skipping

With vector packed decimal instructions, i2pd and l2pd conversions and truncations can be done in one instruction. Thus, the pdshlOverflow above i2pd or l2pd nodes can be omitted. This change makes sure we skip the left shift only if the i2pd or l2pd is an unevaluated single reference node. Signed-off-by: Nigel Yu <[email protected]>
ncough · Oct 19, 2017 · a3cc5dd · a3cc5dd
1 parent 163bdfc
commit a3cc5dd
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/runtime/tr.source/trj9/z/codegen/J9TreeEvaluator.cpp b/runtime/tr.source/trj9/z/codegen/J9TreeEvaluator.cpp
@@ -23201,7 +23201,8 @@ J9::Z::TreeEvaluator::pdshlVectorEvaluatorHelper(TR::Node *node, TR::CodeGenerat
    // skip the shift and just return i2pd results.
    bool isSkipShift = node->getOpCodeValue() == TR::pdshlOverflow &&
            (firstChild->getOpCodeValue() == TR::i2pd ||
-            firstChild->getOpCodeValue() == TR::l2pd);
+            firstChild->getOpCodeValue() == TR::l2pd) &&
+           firstChild->isSingleRefUnevaluated();
 
    int32_t shiftAmount = (int32_t)shiftAmountNode->get64bitIntegralValue();
    uint8_t decimalPrecision = node->getDecimalPrecision();