Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed edge case parsing errors #31

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jdmaloney
Copy link
Collaborator

No description provided.

@jdmaloney jdmaloney requested a review from jakerundall November 6, 2024 21:50
@jakerundall
Copy link
Contributor

Looks good to me in terms of the scripting changes. And I know you've verified functionality on dtai-sched.

I have verified the Puppet change on dtai-sched (Slurm 23.02.7) as well (a no-op, as expected, since you'd already updated the scripts there).

I also applied the updated profile to mgsched1 (Slurm 23.11.10). If you don't mind please verify that telemetry coming out of there is as expected.

I have a CC ticket in for Delta and I'm going to wait until it is approved to test on dti-sched (Slurm 23.11.6) but I'm optimistic that it will work fine there if it works fine on mgsched1 since they run the same major version of Slurm.

So I'd say if things look good on mgsched1 then we can merge and just re-adjust if there are problems on dt-sched.

Conditionally approving.

Copy link
Contributor

@jakerundall jakerundall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved conditioned on verification of telemetry coming out of mgsched1.

@jdmaloney
Copy link
Collaborator Author

I've confirmed Magnus telemetry looks good; rebasing and merging

@jdmaloney jdmaloney merged commit 2fe8257 into main Nov 15, 2024
4 checks passed
@jdmaloney jdmaloney deleted the malone12/SVCPLAN-6448/slurm_parsing_issues branch November 15, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants