Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InterpretationEngine v0.1.0 #6

Merged
merged 20 commits into from
May 21, 2024
Merged

InterpretationEngine v0.1.0 #6

merged 20 commits into from
May 21, 2024

Conversation

brownag
Copy link
Member

@brownag brownag commented May 13, 2024

This is draft PR for a v0.1.0 release of InterpretationEngine. With these additions it will be at least theoretically possible to fully evaluate primary rules provided input property data are available.

  • initRuleset() now links hedge and operator functions to nodes of the rule set
  • CVIRLinear() fix for certain specifications of linear function, update example
  • .NULL_NOT_RATED() hedge function uses NaN to represent "Not rated"
    • Performing logic on mix of character and numeric is unwieldy; NaN allows data to be numeric but for "allowable" missing data to be distinguished from rules that should not generate a rating because required missing data are not present or some not rated condition is triggered
  • Add interpret() method for a data.tree ruleset using either data.frame or SpatRaster input for property data
    • The SpatRaster method should be suitable for rasters that do not fit in memory, parallel processing, etc. though more testing is needed with more demanding use cases
  • Miscellaneous documentation cleanup, several new packages in imports
  • Remove message about experimental support for CrispExpression--this logic was added a couple years ago, has been tested, and works well

TODO:

  • 0 and 1 row input to interpret() propdata needs to be handled

@brownag brownag marked this pull request as ready for review May 21, 2024 14:30
@brownag
Copy link
Member Author

brownag commented May 21, 2024

Plan is to merge this and continue refining documentation, examples, vignettes in another PR for actual v0.1 release. Everything changed in this PR is backward compatible based on my testing.

@brownag brownag merged commit af6e5aa into master May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant