Creating meetings could be broken when the alternative host user pick…

…er is used (#222) This patch fixes a regression after the introduction of the alternative host user picker which could result in a situation that meetings could not be created at all as soon as the admin enabled the user picker for alternative hosts.
ncstate-delta · Mar 10, 2021 · ca96dbd · ca96dbd
1 parent 3bcba8c
commit ca96dbd
Showing 1 changed file with 19 additions and 15 deletions.
diff --git a/mod_form.php b/mod_form.php
@@ -457,21 +457,25 @@ public function data_postprocessing($data) {
             // of selected alternative hosts.
 
             // Get latest list of alternative hosts from the DB.
-            $result = $DB->get_field('zoom', 'alternative_hosts', array('meeting_id' => $data->meeting_id), MUST_EXIST);
-            $alternativehostsdb = explode(',', str_replace(';', ',', $result));
-
-            // Get selectable alternative host users based on the capability.
-            $alternativehostschoices = zoom_get_selectable_alternative_hosts_list($this->context);
-
-            // Iterate over the latest list of alternative hosts from the DB.
-            foreach ($alternativehostsdb as $ah) {
-                // If the existing alternative host would not have been selectable.
-                if (!array_key_exists($ah, $alternativehostschoices)) {
-                    // Add the alternative host to the alternative_hosts field.
-                    if ($data->alternative_hosts == '') {
-                        $data->alternative_hosts = $ah;
-                    } else {
-                        $data->alternative_hosts .= ',' . $ah;
+            $result = $DB->get_field('zoom', 'alternative_hosts', array('meeting_id' => $data->meeting_id), IGNORE_MISSING);
+
+            // Proceed only if there is a field of alternative hosts already.
+            if ($result !== false) {
+                $alternativehostsdb = explode(',', str_replace(';', ',', $result));
+
+                // Get selectable alternative host users based on the capability.
+                $alternativehostschoices = zoom_get_selectable_alternative_hosts_list($this->context);
+
+                // Iterate over the latest list of alternative hosts from the DB.
+                foreach ($alternativehostsdb as $ah) {
+                    // If the existing alternative host would not have been selectable.
+                    if (!array_key_exists($ah, $alternativehostschoices)) {
+                        // Add the alternative host to the alternative_hosts field.
+                        if ($data->alternative_hosts == '') {
+                            $data->alternative_hosts = $ah;
+                        } else {
+                            $data->alternative_hosts .= ',' . $ah;
+                        }
                     }
                 }
             }