Quitting the Dao (old) #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are open questions, such was: - should quitting be still classified as a proposal? - should it execute immediately? - how should it behave for non-existing users? - is being tagged for the next cleanup a better approach?
mikedotexe
reviewed
Nov 16, 2021
mikedotexe
reviewed
Nov 16, 2021
mikedotexe
reviewed
Nov 16, 2021
There was a problem hiding this comment.
Overall looking good, thanks. The simulation tests in test_quit were a bit confusing to read with a mixture of closures and functions, but I think we can work with that. Wouldn't hurt to have a bit more high-level comments peppered throughout tests. But also, thanks for the details comments above the functions, that's very helpful.
I'm going to open a pull request on something small that seems worth doing a different way.
Hotfix/remove sim test code
|
Thanks for the review Mike! I had placed the closures into functions, which I agree makes it easier to reason about the code! Can improve the overall commenting as well! I'm closing this issue in favor of #67, which contains updates from main and updated binaries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #41
There are open questions, such was:
quitting is considered a direct action that a user can call, alongside add_proposal and act_proposal .
quitting doesn't cleanup any data besides removing the user account from the roles.
this is still missing the policies questions, as raised on Quitting the DAO #41.