Fix contract #5
Merged
Fix contract #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @race-of-sloths |
|
In the tests I changed it to deposit just over what is required and did enough test checking that it fails depositing just under what is required. Maybe me adding this isn't the best idea since it makes it a little harder to fork |
gagdiez
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure why creating the subaccount and deploying code to it costs a little more than expected (calculated storage cost 1.54905 NEAR, it needs 0.00198 NEAR more). This additional cost is likley the storage used up on init. I just required 0.1 extra NEAR.