Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update storage rent to storage staking scheme #314

Merged
merged 3 commits into from
Aug 1, 2024
Merged

fix: update storage rent to storage staking scheme #314

merged 3 commits into from
Aug 1, 2024

Conversation

amgando
Copy link
Contributor

@amgando amgando commented Jan 29, 2022

No description provided.

@render
Copy link

render bot commented Jan 29, 2022

Your Render PR Server URL is https://nomicon-pr-314.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7qnrunh8vlcge43otlg.

@amgando amgando changed the title update storage rent to storage staking scheme fix: update storage rent to storage staking scheme Jan 29, 2022
bowenwang1996
bowenwang1996 reviewed Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any account with less than this minimum amount will not be able to maintain a responsive contract and will, instead, return an error related to this mismatch in storage vs minimum account balance

This is not precise. What happens is that if you try to do any action that results in a contract going below the threshold, the action would fail with the error mentioned here

@frol frol self-requested a review September 5, 2022 05:18
@frol frol added T-runtime About NEAR Protocol Runtime (actions, Wasm, fees accounting) WG-protocol Protocol Standards Work Group should be accountable labels Sep 5, 2022
@bowenwang1996 bowenwang1996 removed the WG-protocol Protocol Standards Work Group should be accountable label Sep 28, 2022
@frol frol added the WG-unknown No Work Group is currently accountable label Oct 7, 2022
@frol frol added S-draft/needs-author-revision A NEP in the DRAFT stage that needs an author revision. A-NEP-GrammarFix A grammar/typo fix proposal to existing NEP. Once the original author merges changes, we close this. labels Dec 20, 2022
@victorchimakanu
Copy link

Hello everyone, I'd like to understand the current status of this NEP?

@amgando @frol

mfornet
mfornet approved these changes Jul 18, 2024
View reviewed changes
specs/DataStructures/Account.md Outdated Show resolved Hide resolved
@frol frol requested a review from a team as a code owner August 1, 2024 16:22
@frol frol merged commit 0dcb955 into master Aug 1, 2024
3 of 4 checks passed
@frol frol deleted the fix--storage-staking branch August 1, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwang1996 bowenwang1996 bowenwang1996 left review comments

@mfornet mfornet mfornet approved these changes

@frol frol Awaiting requested review from frol

Assignees
No one assigned
Labels
A-NEP-GrammarFix A grammar/typo fix proposal to existing NEP. Once the original author merges changes, we close this. S-draft/needs-author-revision A NEP in the DRAFT stage that needs an author revision. T-runtime About NEAR Protocol Runtime (actions, Wasm, fees accounting) WG-unknown No Work Group is currently accountable
Projects
NEPs
Status: APPROVED FIXES
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amgando @victorchimakanu @frol @bowenwang1996 @mfornet