Added NearMobileWallet in wallet-selector

[erditkurteshiSQA]

Fixes #762.

Added NearMobileWallet via wallet-selector.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
near-discovery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2023 0:53am
near-discovery-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 14, 2023 0:53am

[erditkurteshiSQA]

We found some issues which are reported here in the comment below:
near/wallet-selector#931 (comment)

Just wanted to highlight these before proceeding with the merge

[calebjacob]

The changes look good to me, but I'll defer the approval and merging of this to @charleslavon since there are some unresolved issues with NEAR Mobile Wallet based on that issue you linked. I'm not sure if we want to hold off until those issues are resolved?

[shelegdmitriy]

Is this means we need to wait to new release of wallet-selector? It seems this issue

We found some issues which are reported here in the comment below:
near/wallet-selector#931 (comment)

was merged

[mpeterdev]

@charleslavon you may want to check in on the output of this thread before we merge: https://pagodaplatform.slack.com/archives/CT45MHDH7/p1698075035123169

[erditkurteshiSQA]

Is this means we need to wait to new release of wallet-selector? It seems this issue

We found some issues which are reported here in the comment below:
near/wallet-selector#931 (comment)

was merged

We need to wait for a new wallet-selector release.
NearMobileWallet team should fix these issues, so the wallet-selector team can continue with the release.
These were found after merging the pr.

[charleslavon]

Thanks for the tag @mpeterdev

Let's hold on merging this until the NearMobileWallet team responds to the branding guidelines conversation that was recently started.

[erditkurteshiSQA]

There is a new wallet-selector release and the nearMobileWallet team fixed the issue with QR code.

[charleslavon]

Thanks for the tag @mpeterdev

Let's hold on merging this until the NearMobileWallet team responds to the branding guidelines conversation that was recently started.

I bet they are not going to respond to this. All of their branding at NEARCON used the same very similar looking Near logo. @thisisjoshford @TiffanyGYJ any objecting to not including NearMobileWallet for now? it's not included as an option on near.social

[thisisjoshford]

@thisisjoshford @TiffanyGYJ any objecting to not including NearMobileWallet for now? it's not included as an option on near.social

I have no objections to holding off until the branding conversation is resolved.

[erditkurteshiSQA]

@charleslavon @calebjacob

The pr is updated with the latest versions.
After approval we can merge this one.

[TiffanyGYJ]

I don't have enough context on this to comment but seems like we should be fine as long as there are clear distinctions on choices

[shelegdmitriy]

@charleslavon are we good to merge it? We are not going to wait until this is resolved, right?