feat: update version of near-api-js #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fospring
force-pushed
the
feat/update-near-api-js-version
branch
2 times, most recently
from
ea9dc10
to
eb02ee4
Compare
fospring
force-pushed
the
feat/update-near-api-js-version
branch
2 times, most recently
from
e1e79b7
to
df2d4a0
Compare
fospring
force-pushed
the
feat/update-near-api-js-version
branch
from
df2d4a0
to
da3011d
Compare
ailisp
reviewed
Nov 22, 2023
| @@ -217,7 +216,7 @@ export abstract class AccountManager implements NearAccountManager { | |||
| } | |||
|
|
|||
| protected get connection(): nearAPI.Connection { | |||
| return new nearAPI.Connection(this.networkId, this.provider, this.signer); | |||
| return new nearAPI.Connection(this.networkId, this.provider, this.signer, `jsvm.${this.networkId}`); | |||
There was a problem hiding this comment.
No, constructor of Connection changed: https://github.com/near/near-api-js/blob/master/packages/accounts/src/connection.ts#L41
ailisp
reviewed
Nov 22, 2023
There was a problem hiding this comment.
transaction-result.ts is not changed, is dist rebuilt after resolve the conflict?
There was a problem hiding this comment.
yep, I rebuit it in the directory of packages/js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency of near-api-js was too old，update it from
0.44.1to2.1.4