Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wallet Connect - Fireblocks #1004

Closed
Calcifer1001 opened this issue Nov 7, 2023 · 16 comments
Closed

[Bug] Wallet Connect - Fireblocks #1004

Calcifer1001 opened this issue Nov 7, 2023 · 16 comments
Assignees
Labels
bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda

Comments

@Calcifer1001
Copy link
Contributor

Describe the bug

After logging in using wallet connect and fireblocks, any time I try to do a transaction of any sort I get the error Uncaught (in promise) {code: -32000, message: 'Server error'}

Steps To Reproduceå

Steps to reproduce the behavior:

  1. Go to https://fireblocks-minimalist-test.vercel.app/
  2. Click on Connect
  3. Choose Wallet connect and scan the QR code using a fireblocks testnet account
  4. When finishing log in, click on Stake 1 NEAR
  5. Check the console

Error description

It is expected to get a QR code to scan with fireblocks and stake 1 NEAR

Screenshots

image

Desktop:

  • OS : Linux zorin
  • Browser : Chrome
  • Browser Version : Version 119.0.6045.105 (Official Build) (64-bit)

Additional Context

In order to make this simpler, I've created this minimalist example. The vercel link above points to the same repo.

To replicate the real scenario, I left the @near-wallet-selector/wallet-connect version to "6.0.0" since when updating it into the real project has an error and when using the newest in this minimalist example I get another error, telling Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://verify.walletconnect.com') does not match the recipient window's origin ('https://fireblocks-minimalist-test.vercel.app') when clicking on Wallet connect in the modal

@Calcifer1001 Calcifer1001 added bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda Near BOS labels Nov 7, 2023
@kujtimprenkuSQA
Copy link
Contributor

Hi, @Calcifer1001 thanks for raising this issue.

updating it into the real project has an error and when using the newest in this minimalist example I get another error, telling Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://verify.walletconnect.com') does not match the recipient window's origin ('https://fireblocks-minimalist-test.vercel.app') when clicking on Wallet connect in the modal

This error can be ignored or you can verify your domain in WalletConnect https://cloud.walletconnect.com/app - Click Project Id then Domain verification

We would appreciate it if you create a demo with a version of @near-wallet-selector/wallet-connect v7.0.3 or higher since any version lower than 7.0.0 is not implemented according to the bridge wallets standard.

@kujtimprenkuSQA kujtimprenkuSQA self-assigned this Nov 7, 2023
@kujtimprenkuSQA
Copy link
Contributor

kujtimprenkuSQA commented Nov 7, 2023

  1. Choose Wallet connect and scan the QR code using a fireblocks testnet account

How can we get a Fireblocks testnet account?

With which wallet are you trying to sign and send these transactions?

@kujtimprenkuSQA
Copy link
Contributor

kujtimprenkuSQA commented Nov 7, 2023

It is expected to get a QR code to scan with fireblocks and stake 1 NEAR

In the wallet-connect option, you only scan the QR code once to connect with the wallet, not every time you signAndSendTransaction(s) once the near_signTransaction or near_signTransactions is triggered with a transaction that needs confirmation, the wallet should automatically prompt you to confirm.

@Calcifer1001
Copy link
Contributor Author

I'll try what you suggested.

Regarding fireblocks, you should be able to get a testnet account here

@kujtimprenkuSQA
Copy link
Contributor

I'll try what you suggested.

Regarding fireblocks, you should be able to get a testnet account here

Hi, while I wait for Fireblocks to activate the account for me.

I tested your demo with the web-examples of WalletConnect where we added support for NEAR:
Wallet Example (testnet): https://react-wallet.walletconnect.com/
you might need to switch to settings tab and enable testnets

I noticed that in the transaction to stake 1 NEAR the receiverId is missing:

sign-transaction

@kieranbop1990
Copy link

I am seeing this exact issue too. I pulled down the examples repository and installed and set my Wallet connect ID but I can't even get it to form a connection.

@kujtimprenkuSQA
Copy link
Contributor

kujtimprenkuSQA commented Nov 9, 2023

Can you provide a demo where the issue is reproduced?

I tested our example: https://near.github.io/wallet-selector/
With the wallet-example: https://react-wallet.walletconnect.com/walletconnect
I did not see any issue there, I was able to connect/signIn and sign and send transactions.

The example provided by @Calcifer1001 seems to be private: https://github.com/Meta-Pool/fireblocks-minimalist-test

I have requested an account from Fireblocks but they have not responded yet, is there any way I can get an account faster?

@kujtimprenkuSQA
Copy link
Contributor

Here's a video trying out this example provided above: https://fireblocks-minimalist-test.vercel.app/

demo.webm

@kujtimprenkuSQA
Copy link
Contributor

I am seeing this exact issue too. I pulled down the examples repository and installed and set my Wallet connect ID but I can't even get it to form a connection.

What examples repository have you pulled down?

@kieranbop1990
Copy link

Hey @kujtimprenkuSQA . I am using the react app in the examples for the wallet-connector. When I try and connect to fireblocks it just shows rejected. I see your dependency bump. I will try that now.

@kujtimprenkuSQA
Copy link
Contributor

Hey @kujtimprenkuSQA . I am using the react app in the examples for the wallet-connector. When I try and connect to fireblocks it just shows rejected. I see your dependency bump. I will try that now.

Hi, can you move to this branch locally: https://github.com/near/wallet-selector/tree/bump-wallet-connect-deps

  1. run: yarn && yarn build:all
  2. Set WalletConnect projectId here
  3. run yarn nx serve react

Try connecting the fireblocks wallet again.

If this does not work could you remove near_signMessage method and refresh the example and try to connect again and see if this is causing any issues.

I will see to find a way to get a Fireblocks account and troubleshoot it asap.

@kujtimprenkuSQA
Copy link
Contributor

We just published a new version of wallet selector v8.7.2 in which we bumped the WalletConnect dependencies to the latest version, can you try it with this version and see how it goes?

Tested WalletConnect option with https://react-wallet.walletconnect.com/ and https://optowallet.com/ (now deprecated, but still works fine) wallet-connect option is working fine with these two.

Note: We did not change any functionality on our side in the wallet-connect option with the exception of adding a new method near_signMessage which should not be a breaking change unless Fireblocks has some specific implementation that does not allow new methods.


We have applied for an account in Fireblocks but we never got any reply from them, is there any other way we could get an account?

@kujtimprenkuSQA
Copy link
Contributor

Hi, @Calcifer1001 & @kieranbop1990 have you tested the latest version of Wallet Selector, are you still having issues with Fireblocks?

@kujtimprenkuSQA
Copy link
Contributor

I have requested a demo from Fireblocks multiple times and have emailed them this week, still waiting for a response from them.

@AmmarHumackicSQA
Copy link
Contributor

Hi, @Calcifer1001 & @kieranbop1990 have you tested the latest version of Wallet Selector, are you still having issues with Fireblocks?

Hi @Calcifer1001 @kieranbop1990 any news regarding this 👆 ? Thanks!

@AmmarHumackicSQA
Copy link
Contributor

Hi @Calcifer1001 @kieranbop1990 , I will close this issue for now, as there has been no reply for a while. Feel free to reopen it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Emerging Tech Emerging Tech flying formation at Pagoda
Projects
None yet
Development

No branches or pull requests

4 participants