Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum tx show details - skipSignInAccessKey bugfix #1221

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Ethereum tx show details - skipSignInAccessKey bugfix #1221

merged 2 commits into from
Nov 7, 2024

Conversation

paouvrard
Copy link
Member

Bug fixes:

  • Ethereum transaction details button state (don't close the details when signing the transaction)
  • During account or network switch, if skipSignInAccessKey is active then disconnecting is not necessary.

@paouvrard paouvrard changed the title Pa/show details Ethereum tx show details - skipSignInAccessKey bugfix Oct 25, 2024
@paouvrard paouvrard mentioned this pull request Oct 28, 2024
Merged
@paouvrard paouvrard requested a review from gtsonevv October 31, 2024 09:53
@paouvrard paouvrard merged commit b93c492 into near:dev Nov 7, 2024
7 checks passed
@Emadalshamery Emadalshamery mentioned this pull request Nov 13, 2024
Closed
@gtsonevv gtsonevv mentioned this pull request Dec 13, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsonevv gtsonevv gtsonevv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paouvrard @gtsonevv