Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring boilerplate Wallet class in core library #1276

Closed
wants to merge 5 commits into from

Conversation

denbite
Copy link
Contributor

@denbite denbite commented Jan 8, 2025

@gagdiez
Copy link
Collaborator

gagdiez commented Jan 8, 2025

While I like the idea of bringing all the commonly used interface, I think it would be nicer if we could get it directly implemented in the Wallet, so people does not need to create a new object to use these methods

By implementing it in the wallets we should be able to also use the provider that the user configured on the selector, instead to instantiate a new one

@gagdiez gagdiez self-requested a review January 28, 2025 17:48
@gagdiez
Copy link
Collaborator

gagdiez commented Jan 28, 2025

@trechriron I have tested this extensively and it works well, it has my approval to go

@gagdiez
Copy link
Collaborator

gagdiez commented Jan 29, 2025

@race-of-sloths are you here?

@race-of-sloths
Copy link

race-of-sloths commented Jan 29, 2025

@denbite Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: stale

This pull request was removed from the race, but you can include it again with @race-of-sloths include command

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@elliotBraem
Copy link

Yessss get this merged and next release ASAP

@gagdiez
Copy link
Collaborator

gagdiez commented Feb 5, 2025

closed in favor of #1284

@gagdiez gagdiez closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

4 participants