-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bring boilerplate Wallet
class in core
library
#1276
Conversation
While I like the idea of bringing all the commonly used interface, I think it would be nicer if we could get it directly implemented in the By implementing it in the wallets we should be able to also use the |
@trechriron I have tested this extensively and it works well, it has my approval to go |
@race-of-sloths are you here? |
@denbite Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: staleThis pull request was removed from the race, but you can include it again with What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Yessss get this merged and next release ASAP |
closed in favor of #1284 |
A lot of projects that use
wallet-selector
are forced to put in their project boilerplate code ofWallet
class over and over againhttps://github.com/phoenixpulsar/auto-chain-verify/blob/master/src/wallets/near.js
https://github.com/aarav1656/near-ai-agent/blob/master/src/app/utils/near-wallet.js
https://github.com/finowl-near/finowl-app/blob/main/frontend/src/app/Wallets/near.js
https://github.com/partagexyz/fans-club/blob/main/src/wallets/near.js
https://github.com/NEARBuilders/devhub-rebuild-with-requests/blob/main/src/wallets/near-wallet.ts
https://github.com/LewinJun/near-demo/blob/0bc0e73ede2175a9b8ed964f66848281d2bb0ca2/my-books/src/wallets/near.js
and many more
This PR addresses the problem by extending
WalletSelector
interface.