-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQC-153: Support for verifyOwner
#320
Closed
Closed
Changes from 37 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
f7dffdd
Added types for signMessage.
lewis-sqa 737321e
Added signMessage for Math Wallet.
lewis-sqa cde5488
Added signMessage for Ledger.
lewis-sqa 2ae941f
Added account method.
lewis-sqa f873dca
Added signMessage for Sender.
lewis-sqa 0862c56
Added signMessage for (My) NEAR Wallet.
lewis-sqa fda1434
Added signMessage for WalletConnect.
lewis-sqa b126b34
Merge remote-tracking branch 'origin/dev' into SQAC-167/sign-message
lewis-sqa 55b8fec
Added demo for sign message functionality.
lewis-sqa 775ca89
Added note around weird behaviour with Sender.
lewis-sqa 02c7187
Added note around weird behaviour with Math Wallet.
lewis-sqa 3fdc892
Merge remote-tracking branch 'origin/dev' into SQAC-167/sign-message
lewis-sqa 3e7d6b6
Aligned with React example.
lewis-sqa c902f81
Updated interfaces.
lewis-sqa 5e5fa6a
Simplified params.
lewis-sqa ae28958
Switched to verifyOwner.
lewis-sqa 7476005
Switched to verifyOwner.
lewis-sqa 8b85581
Added verifyOwner method.
lewis-sqa b0cb0e9
Added logs.
lewis-sqa e75ff19
Switched to verifyOwner.
lewis-sqa 4d7e1ed
Fixed log.
lewis-sqa 0861b90
Switched to verifyOwner.
lewis-sqa 5a9e8f7
Added verifyOwner method.
lewis-sqa cd06612
Switched to verifyOwner.
lewis-sqa 0a80b76
Added log.
lewis-sqa d5d29a3
Switched to verifyOwner.
lewis-sqa 8d0389a
Corrected getPublicKey call.
lewis-sqa 0a8786d
Updated examples.
lewis-sqa aa38a1f
Connect to ledger device, avoid error Device not connected error
kujtimprenkuSQA de59834
Fixed typo
kujtimprenkuSQA 7c1c8b8
Redirect to MyNearWallet
kujtimprenkuSQA 648c168
Throw for ledger since it can only sign transactions at the moment
kujtimprenkuSQA 14c1e62
Catch errors in examples.
kujtimprenkuSQA 1bb4598
Updated docs.
kujtimprenkuSQA d49c461
Throw when callbackUrl can not be constructed, avoid SSR error of win…
kujtimprenkuSQA 1a6e10f
Merged with dev and fixed conflicts
kujtimprenkuSQA e994a8a
Fixed linting
kujtimprenkuSQA 214ae8e
Merge branch 'dev' into SQAC-167/sign-message-2
kujtimprenkuSQA d0f4e2d
Merge branch 'SQAC-167/sign-message-2' into SQAC-167/sign-message
kujtimprenkuSQA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the NEAR Ledger app can only sign valid transactions; it will not be able to sign any payload that is not a transaction -- so this is not implemented currently and should be throwing a 'Method not Supported' type error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, for the feedback. I will make the changes tomorrow when I start working.