-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add signInMulti
method
#811
Open
kujtimprenkuSQA
wants to merge
35
commits into
dev
Choose a base branch
from
SQC-540/add-signin-multi
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
264f904
Added interfaces for signInMulti in wallet types.
kujtimprenkuSQA 627d59b
Add signInMulti method to each wallet.
kujtimprenkuSQA 142ecb3
Merge branch 'dev' into SQC-540/add-signin-multi
kujtimprenkuSQA d40159a
Fix jsdoc warnings and improved docs.
kujtimprenkuSQA 35448f4
Added logic to allow sign-in with multiple contracts.
kujtimprenkuSQA 60ac5a0
Fix build for here wallet.
kujtimprenkuSQA 6e3d5f3
Added contracts to ModalOptions interface.
kujtimprenkuSQA 512f12b
Added logic to handle signInMulti in modal-ui and modal-ui-js.
kujtimprenkuSQA fb519ea
Added docs for .
kujtimprenkuSQA 5f6bfd4
Fix docs since permissions is required for signInMulti.
kujtimprenkuSQA da54351
Remove contracts from setupModal in angular example.
kujtimprenkuSQA 72b83e5
Export MultiContractState interface.
kujtimprenkuSQA 8121e5e
Removed signInMulti from inside the modules instead throw when decora…
kujtimprenkuSQA f910c39
Merge branch 'dev' into SQC-540/add-signin-multi
kujtimprenkuSQA 8d0d967
Removed contractId and added made contracts required, signAndSendTran…
amirsaran3 2f559f7
Added method to update old contract state for signed in users
amirsaran3 1188905
Merge branch 'dev' into SQC-540/add-signin-multi
kujtimprenkuSQA 668d7a4
Trigger signInMulti for ledger when there are multiple contracts.
kujtimprenkuSQA 47bedc6
Merge branch 'dev' into SQC-540/add-signin-multi
kujtimprenkuSQA 970b9d1
Merge branch 'SQC-540/add-signin-multi' into SQC-540/add-signin-multi…
kujtimprenkuSQA 9c487aa
Merge branch 'SQC-540/add-signin-multi' of https://github.com/near/wa…
kujtimprenkuSQA 8433139
Merge branch 'dev' into SQC-540/add-signin-multi
kujtimprenkuSQA 9448d81
Merge branch 'SQC-540/add-signin-multi' into SQC-540/add-signin-multi…
kujtimprenkuSQA 45da765
Merge branch 'dev' into SQC-540/add-signin-multi
kujtimprenkuSQA 6c1e65c
Merge branch 'SQC-540/add-signin-multi' into SQC-540/add-signin-multi…
kujtimprenkuSQA f7bd15e
fix near-mobile-wallet, near-snap and ramper-wallet methods
gtsonevv 1ff90b8
fix if check
gtsonevv 142c447
update receiverId value
gtsonevv 565665d
Merge pull request #1138 from near/SQC-540/add-signin-multi-breaking-…
gtsonevv f39d4b3
Update signedIn emit data; Fix resolveStorageState logic
gtsonevv 7cf58bb
Update docs
gtsonevv ff6d042
Merge pull request #847 from near/SQC-540/add-signin-multi-breaking-c…
gtsonevv 422d9fb
Merge branch 'dev' into SQC-540/add-signin-multi
gtsonevv aa0db8a
Fix merge issues
gtsonevv 180f5b8
Fix modal errors
gtsonevv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having every wallet module be required by convention to implement a
signInMulti()
method thatthrow
's an error if it isn't supported, can we instead not add asignInMulti()
method in the modules that do not support it, and make this decorator check if the method exists and throw the errorif it hasn't been implemented?
This has two benefits:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed it in this commit: 8121e5e