Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change the logic for waiting about the isSignedIn() in Sender #945

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

kujtimprenkuSQA
Copy link
Contributor

@kujtimprenkuSQA kujtimprenkuSQA commented Sep 26, 2023

Description

This PR changes logic and the waiting time for the isSignedIn() for Sender Wallet the details can be found here #944 (comment)

  • This waiting time gets triggered only when some other extensions mentioned in the above comment block the Sender wallet from somehow updating the isSignedIn() state this means if these extensions are not installed or the user is not signed in the wallet selector there will be no waiting time.

Closes: #944

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@github-actions github-actions bot changed the title Change the logic for waiting about the isSignedIn() in Sender refactor: Change the logic for waiting about the isSignedIn() in Sender Sep 26, 2023
@kujtimprenkuSQA kujtimprenkuSQA merged commit 1635f1b into dev Sep 27, 2023
14 of 19 checks passed
@kujtimprenkuSQA kujtimprenkuSQA deleted the 994-wait-longer-for-issignedin-on-sender branch September 27, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The isSignedIn() function of Sender Wallet takes too long to get updated
2 participants