fix: parsing code issue + add more logs

nearform · Nov 30, 2023 · 69eb572 · 69eb572
1 parent 0980b77
commit 69eb572
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/functions/createReview/astParsing/index.js b/functions/createReview/astParsing/index.js
@@ -17,10 +17,13 @@ function getParser(fileName) {
   switch (fileExtension) {
     case '.ts':
     case '.tsx':
+      logger.info(`Using TS parser for file ${fileName}`)
       return Parser.extend(tsPlugin())
     case '.jsx':
+      logger.info(`Using JSX parser for file ${fileName}`)
       return Parser.extend(jsxPlugin())
     case '.js':
+      logger.info(`Using standard parser for file ${fileName}`)
       return Parser
   }
   return null
@@ -36,14 +39,16 @@ export function generateAST(fileContent, fileDiff) {
   const parser = getParser(fileDiff.afterName)
   if (!parser) return
   let ast
+  const sourceType = isESMFile(fileContent) ? 'module' : 'commonjs'
   try {
     ast = parser.parse(fileContent, {
-      sourceType: isESMFile(fileContent) ? 'module' : 'commonjs',
+      sourceType: sourceType,
       locations: true
     })
   } catch (err) {
+    logger.info(err)
     logger.info(
-      `Failed to parse the file content for [${fileDiff.afterName}] into AST. Falling back to the loose parser. Error: ${err.message}`
+      `Failed to parse the file content for [${fileDiff.afterName}] with sourceType=${sourceType} into AST. Falling back to the loose parser. Error: ${err.message}`
     )
     ast = LooseParser.parse(fileContent, { locations: true })
   }

diff --git a/functions/createReview/astParsing/rules/no_loop_await.js b/functions/createReview/astParsing/rules/no_loop_await.js
@@ -31,6 +31,8 @@ function isCalleeFunction(node, callFunctionName) {
 
 export function isArrayFunctionCall(node, functionName) {
   return (
+    !!node &&
+    !!node.type &&
     node.type === 'ExpressionStatement' &&
     node.expression.type === 'CallExpression' &&
     (isCalleeOfType(node, 'ArrayExpression') ||

diff --git a/functions/webhook/app.js b/functions/webhook/app.js
@@ -26,6 +26,10 @@ export default async app => {
         await triggerLLMReview(context)
       } else if (shouldTriggerRuleBasedReview(context.payload)) {
         await triggerRuleBasedReview(context)
+      } else {
+        logger.info(
+          `Ignoring event '${context.name}' -> '${context.payload.action}' with id=${context.id}`
+        )
       }
     } catch (error) {
       logger.error(error)

diff --git a/functions/webhook/triggerReviews.js b/functions/webhook/triggerReviews.js
@@ -95,6 +95,7 @@ export function shouldTriggerRuleBasedReview(payload) {
 }
 
 export async function triggerLLMReview(context) {
+  logger.info('Triggering LLM code review')
   const data = await fetchGithubData(context)
   data.reviewType = REVIEW_TYPE.LLM
   const messageId = await publishMessage(data)
@@ -112,6 +113,7 @@ export async function triggerLLMReview(context) {
 }
 
 export async function triggerRuleBasedReview(context) {
+  logger.info('Triggering a rule based code review')
   const data = await fetchGithubData(context)
   data.reviewType = REVIEW_TYPE.RuleBased
   await publishMessage(data)